cmake: Remove SYSTEM from target_link_libraries

This commit is contained in:
OpenSauce04 2025-09-16 15:21:36 +01:00 committed by OpenSauce
parent a674eb8367
commit eb1197a65c

View File

@ -64,7 +64,7 @@ target_link_libraries(catch2 INTERFACE Catch2::Catch2WithMain)
if(USE_SYSTEM_CRYPTOPP) if(USE_SYSTEM_CRYPTOPP)
find_package(cryptopp REQUIRED) find_package(cryptopp REQUIRED)
add_library(cryptopp INTERFACE) add_library(cryptopp INTERFACE)
target_link_libraries(cryptopp SYSTEM INTERFACE cryptopp::cryptopp) target_link_libraries(cryptopp INTERFACE cryptopp::cryptopp)
else() else()
if (WIN32 AND NOT MSVC AND "arm64" IN_LIST ARCHITECTURE) if (WIN32 AND NOT MSVC AND "arm64" IN_LIST ARCHITECTURE)
# TODO: CryptoPP ARM64 ASM does not seem to support Windows unless compiled with MSVC. # TODO: CryptoPP ARM64 ASM does not seem to support Windows unless compiled with MSVC.
@ -89,7 +89,7 @@ target_disable_warnings(dds-ktx)
if(USE_SYSTEM_FMT) if(USE_SYSTEM_FMT)
add_library(fmt INTERFACE) add_library(fmt INTERFACE)
find_package(fmt REQUIRED) find_package(fmt REQUIRED)
target_link_libraries(fmt SYSTEM INTERFACE fmt::fmt) target_link_libraries(fmt INTERFACE fmt::fmt)
else() else()
option(FMT_INSTALL "" ON) option(FMT_INSTALL "" ON)
add_subdirectory(fmt EXCLUDE_FROM_ALL) add_subdirectory(fmt EXCLUDE_FROM_ALL)
@ -101,7 +101,7 @@ if ("x86_64" IN_LIST ARCHITECTURE)
if(USE_SYSTEM_XBYAK) if(USE_SYSTEM_XBYAK)
find_package(xbyak REQUIRED) find_package(xbyak REQUIRED)
add_library(xbyak INTERFACE) add_library(xbyak INTERFACE)
target_link_libraries(xbyak SYSTEM INTERFACE xbyak::xbyak) target_link_libraries(xbyak INTERFACE xbyak::xbyak)
else() else()
add_subdirectory(xbyak EXCLUDE_FROM_ALL) add_subdirectory(xbyak EXCLUDE_FROM_ALL)
endif() endif()
@ -117,7 +117,7 @@ if ("x86_64" IN_LIST ARCHITECTURE OR "arm64" IN_LIST ARCHITECTURE)
if(USE_SYSTEM_DYNARMIC) if(USE_SYSTEM_DYNARMIC)
find_package(dynarmic REQUIRED) find_package(dynarmic REQUIRED)
add_library(dynarmic INTERFACE) add_library(dynarmic INTERFACE)
target_link_libraries(dynarmic SYSTEM INTERFACE dynarmic::dynarmic) target_link_libraries(dynarmic INTERFACE dynarmic::dynarmic)
# The dynarmic package's cmake files are helpfully completely silent # The dynarmic package's cmake files are helpfully completely silent
# so we have to inform the user of its status ourselves # so we have to inform the user of its status ourselves
if(TARGET dynarmic::dynarmic) if(TARGET dynarmic::dynarmic)
@ -140,7 +140,7 @@ endif()
if(USE_SYSTEM_INIH) if(USE_SYSTEM_INIH)
find_package(inih REQUIRED COMPONENTS inih inir) find_package(inih REQUIRED COMPONENTS inih inir)
add_library(inih INTERFACE) add_library(inih INTERFACE)
target_link_libraries(inih SYSTEM INTERFACE inih::inih inih::inir) target_link_libraries(inih INTERFACE inih::inih inih::inir)
else() else()
add_subdirectory(inih) add_subdirectory(inih)
endif() endif()
@ -221,7 +221,7 @@ if(USE_SYSTEM_ZSTD)
if(TARGET zstd::libzstd_shared) if(TARGET zstd::libzstd_shared)
message(STATUS "Found system Zstandard") message(STATUS "Found system Zstandard")
endif() endif()
target_link_libraries(zstd SYSTEM INTERFACE zstd::libzstd_shared) target_link_libraries(zstd INTERFACE zstd::libzstd_shared)
else() else()
set(ZSTD_LEGACY_SUPPORT OFF) set(ZSTD_LEGACY_SUPPORT OFF)
set(ZSTD_BUILD_PROGRAMS OFF) set(ZSTD_BUILD_PROGRAMS OFF)
@ -256,7 +256,7 @@ endif()
if(USE_SYSTEM_ENET) if(USE_SYSTEM_ENET)
find_package(libenet REQUIRED) find_package(libenet REQUIRED)
add_library(enet INTERFACE) add_library(enet INTERFACE)
target_link_libraries(enet SYSTEM INTERFACE libenet::libenet) target_link_libraries(enet INTERFACE libenet::libenet)
else() else()
add_subdirectory(enet) add_subdirectory(enet)
target_include_directories(enet INTERFACE ./enet/include) target_include_directories(enet INTERFACE ./enet/include)
@ -267,7 +267,7 @@ if (ENABLE_CUBEB)
if(USE_SYSTEM_CUBEB) if(USE_SYSTEM_CUBEB)
find_package(cubeb REQUIRED) find_package(cubeb REQUIRED)
add_library(cubeb INTERFACE) add_library(cubeb INTERFACE)
target_link_libraries(cubeb SYSTEM INTERFACE cubeb::cubeb) target_link_libraries(cubeb INTERFACE cubeb::cubeb)
if(TARGET cubeb::cubeb) if(TARGET cubeb::cubeb)
message(STATUS "Found system cubeb") message(STATUS "Found system cubeb")
endif() endif()
@ -346,7 +346,7 @@ if(USE_SYSTEM_CPP_HTTPLIB)
target_disable_warnings(httplib) target_disable_warnings(httplib)
else() else()
if(CppHttp_FOUND) if(CppHttp_FOUND)
target_link_libraries(httplib SYSTEM INTERFACE httplib::httplib) target_link_libraries(httplib INTERFACE httplib::httplib)
else() else()
message(STATUS "Cpp-httplib not found or not suitable version! Falling back to bundled...") message(STATUS "Cpp-httplib not found or not suitable version! Falling back to bundled...")
target_include_directories(httplib INTERFACE ./httplib) target_include_directories(httplib INTERFACE ./httplib)
@ -369,7 +369,7 @@ if (ENABLE_WEB_SERVICE)
if (USE_SYSTEM_CPP_JWT) if (USE_SYSTEM_CPP_JWT)
find_package(cpp-jwt REQUIRED) find_package(cpp-jwt REQUIRED)
add_library(cpp-jwt INTERFACE) add_library(cpp-jwt INTERFACE)
target_link_libraries(cpp-jwt SYSTEM INTERFACE cpp-jwt::cpp-jwt) target_link_libraries(cpp-jwt INTERFACE cpp-jwt::cpp-jwt)
else() else()
add_library(cpp-jwt INTERFACE) add_library(cpp-jwt INTERFACE)
target_include_directories(cpp-jwt INTERFACE ./cpp-jwt/include) target_include_directories(cpp-jwt INTERFACE ./cpp-jwt/include)
@ -382,7 +382,7 @@ endif()
if(USE_SYSTEM_LODEPNG) if(USE_SYSTEM_LODEPNG)
add_library(lodepng INTERFACE) add_library(lodepng INTERFACE)
find_package(lodepng REQUIRED) find_package(lodepng REQUIRED)
target_link_libraries(lodepng SYSTEM INTERFACE lodepng::lodepng) target_link_libraries(lodepng INTERFACE lodepng::lodepng)
else() else()
add_subdirectory(lodepng) add_subdirectory(lodepng)
endif() endif()
@ -399,7 +399,7 @@ if (ENABLE_OPENAL)
if(USE_SYSTEM_OPENAL) if(USE_SYSTEM_OPENAL)
add_library(OpenAL INTERFACE) add_library(OpenAL INTERFACE)
find_package(OpenAL REQUIRED) find_package(OpenAL REQUIRED)
target_link_libraries(OpenAL SYSTEM INTERFACE OpenAL::OpenAL) target_link_libraries(OpenAL INTERFACE OpenAL::OpenAL)
else() else()
set(ALSOFT_EMBED_HRTF_DATA OFF CACHE BOOL "") set(ALSOFT_EMBED_HRTF_DATA OFF CACHE BOOL "")
set(ALSOFT_EXAMPLES OFF CACHE BOOL "") set(ALSOFT_EXAMPLES OFF CACHE BOOL "")
@ -468,7 +468,7 @@ if (ENABLE_VULKAN)
find_package(VulkanMemoryAllocator REQUIRED) find_package(VulkanMemoryAllocator REQUIRED)
if(TARGET GPUOpen::VulkanMemoryAllocator) if(TARGET GPUOpen::VulkanMemoryAllocator)
message(STATUS "Found VulkanMemoryAllocator") message(STATUS "Found VulkanMemoryAllocator")
target_link_libraries(vma SYSTEM INTERFACE GPUOpen::VulkanMemoryAllocator) target_link_libraries(vma INTERFACE GPUOpen::VulkanMemoryAllocator)
endif() endif()
else() else()
add_library(vma INTERFACE) add_library(vma INTERFACE)
@ -482,7 +482,7 @@ if (ENABLE_VULKAN)
find_package(Vulkan REQUIRED) find_package(Vulkan REQUIRED)
if(TARGET Vulkan::Headers) if(TARGET Vulkan::Headers)
message(STATUS "Found Vulkan headers") message(STATUS "Found Vulkan headers")
target_link_libraries(vulkan-headers SYSTEM INTERFACE Vulkan::Headers) target_link_libraries(vulkan-headers INTERFACE Vulkan::Headers)
endif() endif()
else() else()
target_include_directories(vulkan-headers INTERFACE ./vulkan-headers/include) target_include_directories(vulkan-headers INTERFACE ./vulkan-headers/include)