From 859908cb1f8f3b7fdef10e3ad6a0e000d62324af Mon Sep 17 00:00:00 2001
From: Andry Yosua <andry.yosua@gmail.com>
Date: Thu, 14 Sep 2023 13:53:48 +0700
Subject: [PATCH] Don't show audio language option if language is undetermined
 (#2937)

* Don't show audio language option if language is undetermined

as a viewer
i want simple option
so i
  - don't need to see unnecessary option
  - have more simple option
by not showing audio language option if language is undetermined

fix https://github.com/TeamPiped/Piped/issues/1761

* looks simpler and more self-explaining
---
 src/components/VideoPlayer.vue | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/components/VideoPlayer.vue b/src/components/VideoPlayer.vue
index 94063864..accf052e 100644
--- a/src/components/VideoPlayer.vue
+++ b/src/components/VideoPlayer.vue
@@ -472,14 +472,7 @@ export default {
 
                 this.$ui = new shaka.ui.Overlay(localPlayer, this.$refs.container, videoEl);
 
-                const overflowMenuButtons = [
-                    "quality",
-                    "language",
-                    "captions",
-                    "picture_in_picture",
-                    "playback_rate",
-                    "airplay",
-                ];
+                const overflowMenuButtons = ["quality", "captions", "picture_in_picture", "playback_rate", "airplay"];
 
                 if (this.isEmbed) {
                     overflowMenuButtons.push("open_new_tab");
@@ -544,6 +537,18 @@ export default {
                         player.selectAudioLanguage(lang);
                     }
 
+                    const audioLanguages = player.getAudioLanguages();
+                    if (audioLanguages.length > 1) {
+                        const overflowMenuButtons = this.$ui.getConfiguration().overflowMenuButtons;
+                        // append language menu on index 1
+                        const newOverflowMenuButtons = [
+                            ...overflowMenuButtons.slice(0, 1),
+                            "language",
+                            ...overflowMenuButtons.slice(1),
+                        ];
+                        this.$ui.configure("overflowMenuButtons", newOverflowMenuButtons);
+                    }
+
                     if (qualityConds) {
                         var leastDiff = Number.MAX_VALUE;
                         var bestStream = null;